Skip to content

BUG: Add mapping for pyqt for successful package installation #27645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 7, 2019
Merged

BUG: Add mapping for pyqt for successful package installation #27645

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6576f9b
Add mapping for pyqt
charlesdong1991 Jul 29, 2019
c49823c
Add whatsnew in 0.25.1
charlesdong1991 Jul 29, 2019
bbeb533
change to rename
charlesdong1991 Jul 29, 2019
92a9938
add versiona and run again
charlesdong1991 Jul 30, 2019
59d1317
Move whatsnew note
charlesdong1991 Jul 30, 2019
af78682
Change name in env.yaml
charlesdong1991 Jul 30, 2019
dab50e7
Change env.yaml
charlesdong1991 Jul 30, 2019
785cef9
Merge remote-tracking branch 'upstream/master' into charlesdong1991-i…
TomAugspurger Aug 1, 2019
b37f0ac
Resubmit
charlesdong1991 Aug 2, 2019
6dbe2ac
Fix typo
charlesdong1991 Aug 5, 2019
7307758
Merge branch 'issue_26838' of github.com:charlesdong1991/pandas into …
charlesdong1991 Aug 5, 2019
b25d83b
Rephrase whatsnew note
charlesdong1991 Aug 5, 2019
29decf9
Resubmit PR
charlesdong1991 Aug 6, 2019
2c9186e
Merge remote-tracking branch 'upstream/master' into issue_26838
charlesdong1991 Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ ExtensionArray
Other
^^^^^

-
- Add pyqt in RENAME dictionary in `generate_pip_deps_from_conda.py` to fix installation failure of pandas (:issue:`26838`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing generate_pip_deps_from_conda.py probably isn't relevant to users. Let's just write this as "Fixed pyqt development dependency."

This doesn't need to be back ported, so you can remove the release note or move it to 1.0.0.rst

-
-

Expand Down
2 changes: 1 addition & 1 deletion scripts/generate_pip_deps_from_conda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@


EXCLUDE = {"python=3"}
RENAME = {"pytables": "tables"}
RENAME = {"pytables": "tables", "pyqt": "pyqt5"}


def conda_package_to_pip(package):
Expand Down