Skip to content

re-implement #27959 #28260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

re-implement #27959 #28260

merged 1 commit into from
Sep 3, 2019

Conversation

jbrockmendel
Copy link
Member

Previous version broke because a different branch changed the behavior of when extract_array is called.

@TomAugspurger
Copy link
Contributor

Any idea why this wasn't caught by CI the first time around?

@TomAugspurger TomAugspurger added this to the 1.0 milestone Sep 3, 2019
@jbrockmendel
Copy link
Member Author

Any idea why this wasn't caught by CI the first time around?

Between the time when the #27959 went up and the time when it was merged, a different PR changed the expected inputs to dispatch_to_extension_op. Previously extract_array was called inside dispatch_to_extension_op, but that was changed to expect the inputs to already be extracted. 27959 was calling using the older convention, which led to RecursionError.

TomAugspurger
TomAugspurger approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks.

@TomAugspurger TomAugspurger added the ExtensionArray Extending pandas with custom dtypes or arrays. label Sep 3, 2019
@TomAugspurger TomAugspurger merged commit 9777e84 into pandas-dev:master Sep 3, 2019
@jbrockmendel jbrockmendel deleted the unrevert branch September 3, 2019 19:04
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: use dispatch_to_extension_op for bool ops (pandas-dev#28260)
3ce3963 
re-implement pandas-dev#27959, which was previously merged and reverted.
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: use dispatch_to_extension_op for bool ops (pandas-dev#28260)
2f95230 
re-implement pandas-dev#27959, which was previously merged and reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @TomAugspurger