-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: add example of pyarrow usage favored over the deprecated to_msgpack #28494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add example of pyarrow usage favored over the deprecated to_msgpack #28494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, small comment.
Awesome, but I don't understand what you meant by "small comment". I don't see any reviews in the PR |
doc/source/whatsnew/v1.0.0.rst
Outdated
@@ -206,6 +206,7 @@ I/O | |||
- Improve infinity parsing. :meth:`read_csv` now interprets ``Infinity``, ``+Infinity``, ``-Infinity`` as floating point values (:issue:`10065`) | |||
- Bug in :meth:`DataFrame.to_csv` where values were truncated when the length of ``na_rep`` was shorter than the text input data. (:issue:`25099`) | |||
- Bug in :func:`DataFrame.to_string` where values were truncated using display options instead of outputting the full content (:issue:`9784`) | |||
- Docs for the deprecated :func:`DataFrame.to_msgpack` give an example usage of the recommended pyarrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this note is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback -- Dont leave people hanging -- notes cost nothing. Since the deprecation caused the problem to a good code. Hint to solution - instead of a blind door. msgpack are very concise object. pyarrow dont know.. leave breadcrumbs..
13b8f4a
to
96f8637
Compare
lgtm ping on green. |
ping (is green) |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff