Skip to content

DOC: add example of pyarrow usage favored over the deprecated to_msgpack #28494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shadiakiki1986
Copy link
Contributor

  • closes #xxxx
    • no issue opened
  • tests added / passed
    • no, only docs modified
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added this to the 1.0 milestone Sep 18, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small comment.

@shadiakiki1986
Copy link
Contributor Author

Awesome, but I don't understand what you meant by "small comment". I don't see any reviews in the PR

@@ -206,6 +206,7 @@ I/O
- Improve infinity parsing. :meth:`read_csv` now interprets ``Infinity``, ``+Infinity``, ``-Infinity`` as floating point values (:issue:`10065`)
- Bug in :meth:`DataFrame.to_csv` where values were truncated when the length of ``na_rep`` was shorter than the text input data. (:issue:`25099`)
- Bug in :func:`DataFrame.to_string` where values were truncated using display options instead of outputting the full content (:issue:`9784`)
- Docs for the deprecated :func:`DataFrame.to_msgpack` give an example usage of the recommended pyarrow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this note is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Removed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback -- Dont leave people hanging -- notes cost nothing. Since the deprecation caused the problem to a good code. Hint to solution - instead of a blind door. msgpack are very concise object. pyarrow dont know.. leave breadcrumbs..

@shadiakiki1986 shadiakiki1986 force-pushed the to_msgpack-example_pyarrow branch from 13b8f4a to 96f8637 Compare September 18, 2019 12:35
@jreback
Copy link
Contributor

jreback commented Sep 18, 2019

lgtm ping on green.

@shadiakiki1986
Copy link
Contributor Author

ping (is green)

@jreback jreback merged commit 024d207 into pandas-dev:master Sep 18, 2019
@shadiakiki1986 shadiakiki1986 deleted the to_msgpack-example_pyarrow branch September 19, 2019 11:55
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants