Skip to content

Fix docstring error #28598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix docstring error #28598

wants to merge 6 commits into from

Conversation

WuraolaOyewusi
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@WuraolaOyewusi
Copy link
Contributor Author

Hello Marc @datapythonista .
Kindly confirm if this is as discussed.
Thank you

@jorisvandenbossche
Copy link
Member

Do we rather want to update the validation script to allow this? (because now we are duplicating an explanation that almost nobody needs)

@WuraolaOyewusi
Copy link
Contributor Author

@jorisvandenbossche . That will be faster especially for the *args and **kwargs. Some of the functions with PR02 errors have totally different parameters from their docstrings.
I don't know how to go about updating the validation script. If you have the time, you can put me through.

@datapythonista
Copy link
Member

datapythonista commented Sep 25, 2019 via email

@WuraolaOyewusi
Copy link
Contributor Author

Ok marc. I will check

@WillAyd
Copy link
Member

WillAyd commented Oct 11, 2019

#28811 was just merged and should allow for this, so I don't think this PR is applicable any more.

Thanks of course for the submission @WuraolaOyewusi - there are plenty more out there would welcome contributions on

@WillAyd WillAyd closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants