-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Fix docstring error #28598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstring error #28598
Conversation
Hello Marc @datapythonista . |
Do we rather want to update the validation script to allow this? (because now we are duplicating an explanation that almost nobody needs) |
@jorisvandenbossche . That will be faster especially for the *args and **kwargs. Some of the functions with PR02 errors have totally different parameters from their docstrings. |
Agree with Joris. Any other of the errors in the parameters can be fixed in
the docstrings, but having args and kwargs together is a false positive of
the validation, we should update the script.
I think I opened an issue for this, and not sure if someone was already
working on it. Can you have a look and see if you can find that issue, not
sure if in the mentoring repo or in pandas itself. I'm in my phone with
poor internet connection right now, but will help you later if you can't
find it.
…On Wed, 25 Sep 2019, 13:29 Wuraola Oyewusi, ***@***.***> wrote:
@jorisvandenbossche <https://github.com/jorisvandenbossche> . That will
be faster especially for the *args and **kwargs. Some of the functions with
PR02 errors have totally different parameters from their docstrings.
I don't know how to go about updating the validation script. If you have
the time, you can put me through.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28598?email_source=notifications&email_token=ACMXUAC7LEBH6XOYOU2LG5LQLNKRBA5CNFSM4I2CJ5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RWXXA#issuecomment-534997980>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACMXUAD3KWZIR4BLG2HRE3DQLNKRBANCNFSM4I2CJ5EQ>
.
|
Ok marc. I will check |
#28811 was just merged and should allow for this, so I don't think this PR is applicable any more. Thanks of course for the submission @WuraolaOyewusi - there are plenty more out there would welcome contributions on |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff