CLN: Consistent imports - linting rules #29318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
commented
Nov 1, 2019
| invgrep -R --include="*.py*" -E "from pandas.core.common import" pandas | ||
| invgrep -R --include="*.py*" -E "from pandas.core import common" pandas | ||
| invgrep -R --include="*.py*" -E "from collections.abc import" pandas | ||
| invgrep -R --include="*.py*" -E "from numpy import nan" pandas |
There was a problem hiding this comment.
I removed the trailing spaces in the import strings to make them more robust to multi-line imports.
Also for the from numpy import nan import they didn't make sense at all. It doesn't seem to be valid syntax anymore though, so it doesn't require any additional clean up
| invgrep -R --include="*.py*" -E "from collections.abc import " pandas | ||
| invgrep -R --include="*.py*" -E "from numpy import nan " pandas | ||
| invgrep -R --include="*.py*" -E "from pandas.core.common import" pandas | ||
| invgrep -R --include="*.py*" -E "from pandas.core import common" pandas |
There was a problem hiding this comment.
I noticed the pattern from pandas.core import common as com is used in the code base as an alternative to the desired import pandas.core.common as com. Therefore I fixed the existing cases (not a breaking change) and added this linting rule here. Let me know if that's fine with you or if this should rather go into a separate PR 🙂✌️
SaturnFromTitan
changed the title
|
thanks @SaturnFromTitan very nice! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff