Skip to content

TST: add test for df comparing strings to numbers raises ValueError #29535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2019
Merged

TST: add test for df comparing strings to numbers raises ValueError #29535

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5199fe
add test for comparing strings to numbers df raises ValueError
ganevgv Nov 10, 2019
8f9000b
move test
ganevgv Nov 10, 2019
0b2b6a9
add parameterize over all operators
ganevgv Nov 11, 2019
a3795b3
use compare_operators_no_eq_ne
ganevgv Nov 12, 2019
a70c143
add _rasises to test name
ganevgv Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/frame/test_operators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,14 @@ def test_comp(func):
test_comp(operator.ge)
test_comp(operator.le)

def test_strings_to_numbers_comparisons_raises(self):
# GH 11565
df = DataFrame(
{x: {"x": "foo", "y": "bar", "z": "baz"} for x in ["a", "b", "c"]}
)
with pytest.raises(TypeError):
df > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pytest.mark.parameterize over all the operators? I think we have a fixture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mroeschke - now using parameterize to go over ["lt", "le", "gt", "ge", "eq", "ne"].


def test_comparison_protected_from_errstate(self):
missing_df = tm.makeDataFrame()
missing_df.iloc[0]["A"] = np.nan
Expand Down