Skip to content

CI: Fixed travis-36-cov build #30312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 18, 2019
Merged

Conversation

TomAugspurger
Copy link
Contributor

Closes #30309

Just debugging right now. Can't reproduce locally yet.

@jbrockmendel jbrockmendel added the CI Continuous Integration label Dec 17, 2019
@TomAugspurger
Copy link
Contributor Author

In theory, setting LD_PRELOAD=/opt/conda/lib/libgomp.sov will fix this. Trying to understand the issue a bit more first.

@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

Rather than updating that may also just want to get off of the trusty service since may have been patched in glibc

pytorch/pytorch#2575 (comment)

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Dec 17, 2019

Mmm good to know.

I think we had issues with databases last time I looked. Will see if I can find that thread.

@TomAugspurger
Copy link
Contributor Author

The LD_LIBRARY_PRELOAD thing did the trick, but I'd prefer to solve it more cleanly. Trying Will's suggestion next.

@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

I think also need to add the appropriate DB services for CI to be green:

https://docs.travis-ci.com/user/database-setup/#mysql

@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

Whoops sorry I see you did that one some already, but I guess that's what is causing the CI failure for the ones currently red

@TomAugspurger
Copy link
Contributor Author

Yep, I have a commit to fix that, just waiting for the running job to see if the openmp thing is fixed.

@TomAugspurger
Copy link
Contributor Author

OK that one passed. Took 34 minutes though, compared to 27 in https://travis-ci.org/pandas-dev/pandas/builds/626386764 :/

@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

Hmm yea something watch, though I think the runs normally fluctuate in that range

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

@TomAugspurger
Copy link
Contributor Author

Thanks for the help Will! I'm glad to have avoided the LD_LIBRARY_PRELOAD stuff.

This last run took 32 minutes. I recall some ongoing work to balance these builds a bit, will see if I can track that down.

@TomAugspurger TomAugspurger merged commit 080e331 into pandas-dev:master Dec 18, 2019
@TomAugspurger TomAugspurger deleted the 30309-debug branch December 18, 2019 12:32
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: travis-36-cov failing
3 participants