REF: implement indexes.extension to share delegation #30629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jan 2, 2020
pandas/core/indexes/extension.py
Outdated
| from pandas.util._decorators import cache_readonly | ||
|
|
||
|
|
||
| def inherit_from_data(name, delegate, cache=False): |
|
|
||
| method = property(fget, fset) | ||
|
|
||
| elif not callable(attr): |
There was a problem hiding this comment.
Hmm somewhat confused by this function. Documented as working on methods but seems to accept attributes as well?
There was a problem hiding this comment.
Will update docstring. This clause is for regular class attributes, in particular a few List[str] that we share
jreback
added
ExtensionArray
jreback
requested changes
Jan 3, 2020
| "_field_ops", | ||
| "_datetimelike_ops", | ||
| "_datetimelike_methods", | ||
| ], |
There was a problem hiding this comment.
you have the cache=True ones first in datetimelike, can you conform
| return method | ||
|
|
||
|
|
||
| def inherit_names(names: List[str], delegate, cache: bool = False): |
There was a problem hiding this comment.
you could type this -> Callable[[Type[T]], Type[T]] i think
jreback
approved these changes
Jan 3, 2020
|
k merge on green. |
|
green |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In following steps, I plan to