-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
STY: concat strings that should not be seperated #30942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1491,8 +1491,7 @@ cdef ndarray[float64_t] _roll_weighted_sum_mean(float64_t[:] values, | |
tot_wgt = np.zeros(in_n, dtype=np.float64) | ||
|
||
if minp > win_n: | ||
raise ValueError(f"min_periods (minp) must be <= " | ||
f"window (win)") | ||
raise ValueError(f"min_periods {minp} must be <= window {win_n}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think leave the message unchanged unless obvious improvement and then should add a brief note in whatsnew that message has been changed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'll just delete this |
||
elif minp > in_n: | ||
minp = in_n + 1 | ||
elif minp < 0: | ||
|
@@ -1871,8 +1870,7 @@ def ewmcov(float64_t[:] input_x, float64_t[:] input_y, | |
bint is_observation | ||
|
||
if <Py_ssize_t>len(input_y) != N: | ||
raise ValueError(f"arrays are of different lengths " | ||
f"({N} and {len(input_y)})") | ||
raise ValueError(f"arrays are of different lengths ({N} and {len(input_y)})") | ||
|
||
output = np.empty(N, dtype=float) | ||
if N == 0: | ||
|
Uh oh!
There was an error while loading. Please reload this page.