Skip to content

Use https for links where available #31145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2020

Conversation

rebecca-palmer
Copy link
Contributor

As some of our links are suggestions to install add-on software, insecure links potentially allow an attacker to replace this with their malware.

During the process of writing this, I also found and fixed some broken or semi-broken (e.g. redirected to the top level instead of the page we want) links.

The following (already) broken links remain:
http://nipunbatra.github.io/2015/06/timeseries/ + others from this site
http://collaboration.cmc.ec.gc.ca/science/rpn/biblio/ddj/Website/articles/CUJ/1992/9210/ross/ross.htm
http://mysite.verizon.net/aesir_research/date/jdalg2.htm

@pep8speaks
Copy link

pep8speaks commented Jan 20, 2020

Hello @rebecca-palmer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-21 23:00:06 UTC

@jreback jreback added the Docs label Jan 20, 2020
@jreback
Copy link
Contributor

jreback commented Jan 20, 2020

can you rebase on master.

also if you can add a code_checks for this as well (can be a followup too)

@rebecca-palmer
Copy link
Contributor Author

ci/code_checks.sh looks like it checks everything (not just new changes), so while it would be easy to add "http://" to its banned patterns list, that would fail as long as we have any http links. As some of our existing links (the ones I didn't convert) don't work over https, this is probably not a good idea.

The PEP8 issue isn't new, and involves a link that is >80char by itself.

@ShaharNaveh
Copy link
Member

ci/code_checks.sh looks like it checks everything (not just new changes), so while it would be easy to add "http://" to its banned patterns list, that would fail as long as we have any http links. As some of our existing links (the ones I didn't convert) don't work over https, this is probably not a good idea.

The PEP8 issue isn't new, and involves a link that is >80char by itself.

@rebecca-palmer I think that appending # noqa should do the trick despite the fact that it's inside a comment, so it will look kida like this:

# <comments> <comments>
# <VERY_LARGE_URL> # noqa
# <more comments> <more comments>

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@jreback jreback added this to the 1.1 milestone Jan 24, 2020
@jreback jreback merged commit 2dadd0f into pandas-dev:master Jan 24, 2020
@jreback
Copy link
Contributor

jreback commented Jan 24, 2020

thanks !

raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Mar 1, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Apr 9, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Apr 10, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request May 10, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Jul 2, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Aug 20, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Aug 31, 2020
Also fix some (semi-)broken links found while checking https availability.

Author: Rebecca N. Palmer <[email protected]>
Forwarded: accepted for 1.1 pandas-dev/pandas#31145


Gbp-Pq: Name link_security.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants