-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Use https for links where available #31145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @rebecca-palmer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-21 23:00:06 UTC |
can you rebase on master. also if you can add a code_checks for this as well (can be a followup too) |
ci/code_checks.sh looks like it checks everything (not just new changes), so while it would be easy to add "http://" to its banned patterns list, that would fail as long as we have any http links. As some of our existing links (the ones I didn't convert) don't work over https, this is probably not a good idea. The PEP8 issue isn't new, and involves a link that is >80char by itself. |
@rebecca-palmer I think that appending # <comments> <comments>
# <VERY_LARGE_URL> # noqa
# <more comments> <more comments> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jreback
thanks ! |
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
Also fix some (semi-)broken links found while checking https availability. Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31145 Gbp-Pq: Name link_security.patch
As some of our links are suggestions to install add-on software, insecure links potentially allow an attacker to replace this with their malware.
During the process of writing this, I also found and fixed some broken or semi-broken (e.g. redirected to the top level instead of the page we want) links.
The following (already) broken links remain:
http://nipunbatra.github.io/2015/06/timeseries/ + others from this site
http://collaboration.cmc.ec.gc.ca/science/rpn/biblio/ddj/Website/articles/CUJ/1992/9210/ross/ross.htm
http://mysite.verizon.net/aesir_research/date/jdalg2.htm