Skip to content

REF: implement tests/indexes/objects/ #31597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 5, 2020

Conversation

jbrockmendel
Copy link
Member

Many of the tests in test_base are about Index.__new__ cases that return a subclass. This is intended specifically for Index-only tests.

@jbrockmendel jbrockmendel added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Feb 4, 2020
@jorisvandenbossche
Copy link
Member

Does the "objects" mean "object dtype" or Index "objects" ?

@jbrockmendel
Copy link
Member Author

Does the "objects" mean "object dtype" or Index "objects" ?

Good question, im open to a better name. The idea here is for tests specific to the base Index class

@jorisvandenbossche
Copy link
Member

Maybe something like base_index ?

@jreback jreback added this to the 1.1 milestone Feb 5, 2020
@jreback jreback merged commit 9bfdb0d into pandas-dev:master Feb 5, 2020
@jreback
Copy link
Contributor

jreback commented Feb 5, 2020

great; test_base is huge!

@jbrockmendel jbrockmendel deleted the ref-tst-objindex branch February 5, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants