Skip to content

TST: add regression test for apply case from GH-31605 #31621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Feb 3, 2020

@jorisvandenbossche you wanted to put more tests in for this issue. I put the user reported code example into a test. Did you have anything else in mind? I didn't merge it with the above one since the above acted on an empty Dataframe.

@jorisvandenbossche jorisvandenbossche changed the title Add test for gh 31605 TST: add regression test for apply case from GH-31605 Feb 3, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Feb 3, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think just this test is fine, added two minor comments

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Feb 5, 2020
@jreback jreback merged commit a89f7fd into pandas-dev:master Feb 5, 2020
@jreback
Copy link
Contributor

jreback commented Feb 5, 2020

thanks @fjetter

@fjetter fjetter deleted the add_test_gh31605 branch February 5, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected TypeError with groupby
3 participants