Skip to content

TYP: annotate #32730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 19, 2020
Merged

TYP: annotate #32730

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c1a8ad6
annotations
jbrockmendel Mar 15, 2020
8f7d8aa
Merge branch 'master' of https://github.com/pandas-dev/pandas into an…
jbrockmendel Mar 15, 2020
9bd7fa1
revert
jbrockmendel Mar 15, 2020
071b773
Merge branch 'master' of https://github.com/pandas-dev/pandas into an…
jbrockmendel Mar 16, 2020
cf97e3e
update docstring
jbrockmendel Mar 16, 2020
6aa5c14
Merge branch 'master' of https://github.com/pandas-dev/pandas into an…
jbrockmendel Mar 17, 2020
1ef8585
update check
jbrockmendel Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pandas/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import builtins
import textwrap
from typing import Dict, FrozenSet, List, Optional
from typing import Dict, FrozenSet, List, Optional, Union

import numpy as np

Expand Down Expand Up @@ -34,7 +34,6 @@
from pandas.core.arrays import ExtensionArray
from pandas.core.construction import create_series_with_explicit_dtype
import pandas.core.nanops as nanops
from pandas.typing import ArrayLike
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe no need to revert. this was a typo. pandas.typing -> pandas._typing


_shared_docs: Dict[str, str] = dict()
_indexops_doc_kwargs = dict(
Expand Down Expand Up @@ -599,7 +598,7 @@ class IndexOpsMixin:
)

@property
def _values(self) -> ArrayLike:
def _values(self) -> Union[ExtensionArray, np.ndarray]:
# must be defined here as a property for mypy
raise AbstractMethodError(self)

Expand Down