Skip to content

Issue33955 Properly checking whether post_processing is callable or not in Class GroupBy #33988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Issue33955 Properly checking whether post_processing is callable or not in Class GroupBy #33988

wants to merge 2 commits into from

Conversation

KenilMehta
Copy link
Contributor

jreback
jreback requested changes May 5, 2020
View reviewed changes
pandas/core/groupby/groupby.py
@@ -2236,7 +2236,7 @@ def _get_cythonized_result(
if result_is_index and aggregate:
raise ValueError("'result_is_index' and 'aggregate' cannot both be True!")
if post_processing:
if not callable(pre_processing):
if not callable(post_processing):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test that actually hits this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34372 changes the path for GroupBy.std so that this is hit by std tests.

@jreback jreback added Groupby Compat pandas objects compatability with Numpy or Python functions labels May 5, 2020
@rhshadrach rhshadrach mentioned this pull request Jun 5, 2020
Merged
5 tasks
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

closing in favor of #34372

@jreback jreback closed this Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach left review comments

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Not properly checking if post_processing function is callable or not in _get_cythonized_result() function in class GroupBy
3 participants
@KenilMehta @jreback @rhshadrach