Skip to content

PERF: Remove unnecessary copies in sorting functions (#33917) #34192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 3, 2020
Merged

PERF: Remove unnecessary copies in sorting functions (#33917) #34192

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c94b45e
PERF: Remove unnecessary copies in sorting functions
mproszewska May 15, 2020
0ab450b
Run tests
mproszewska May 16, 2020
54c7304
Run tests
mproszewska May 16, 2020
6d72a34
Add asv
mproszewska May 22, 2020
5ba54a6
Run black
mproszewska May 22, 2020
2766270
Remove asv
mproszewska May 22, 2020
91176ca
Merge branch 'perf'
mproszewska May 24, 2020
f748b78
Merge remote-tracking branch 'upstream/master'
mproszewska May 28, 2020
c04c494
Merge remote-tracking branch 'upstream/master'
mproszewska Jun 1, 2020
b398ccd
Run tests
mproszewska Jun 3, 2020
01b222e
Run tests
mproszewska Jun 3, 2020
48e54dd
Run tests
mproszewska Jun 3, 2020
b71c82a
Run tests
mproszewska Jun 3, 2020
2e7385d
Run tests
mproszewska Jun 3, 2020
a5bd649
Run tests
mproszewska Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions asv_bench/benchmarks/algorithms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,14 @@ def time_argsort(self, N):
self.array.argsort()


class SortIndexSeries:
def setup(self):
N = 10 ** 5
idx = pd.date_range(start="1/1/2000", periods=N, freq="s")
self.s = pd.Series(np.random.randn(N), index=idx)

def time_sort_index(self):
self.s.sort_index()


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this. SortIndex.time_sort_index already covers this code path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I haven't checked timeseries before adding asv

from .pandas_vb_common import setup # noqa: F401 isort:skip
2 changes: 1 addition & 1 deletion pandas/core/sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def ensure_key_mapped(values, key: Optional[Callable], levels=None):
from pandas.core.indexes.api import Index

if not key:
return values.copy()
return values

if isinstance(values, ABCMultiIndex):
return ensure_key_mapped_multiindex(values, key, level=levels)
Expand Down