Skip to content

CLN: update tslibs/tseries test locations/imports #34614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@mroeschke mroeschke added this to the 1.1 milestone Jun 7, 2020
@mroeschke mroeschke added the Clean label Jun 7, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

(offsets.Micro(), offsets.Nano(), True),
],
)
def test_super_sub_symmetry(p1, p2, expected):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity what is the difference between this and the original module for this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current location is in tests.tslibs, which is explicitly aimed at _libs.tslibs (where these functions resided until recently)

@jreback jreback merged commit 79fb1dd into pandas-dev:master Jun 8, 2020
@jbrockmendel jbrockmendel deleted the cln-tests branch June 8, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants