CLN: dont consolidate in NDFrame._is_numeric_mixed_type #34678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
presume that these are either neutral or + on perf |
AFAICT. The main upside is getting rid of a side-effect. |
jorisvandenbossche
requested changes
Jun 10, 2020
pandas/core/generic.py
Outdated
| @@ -5335,8 +5335,7 @@ def _is_mixed_type(self) -> bool_t: | |||
|
|
|||
| @property | |||
| def _is_numeric_mixed_type(self) -> bool_t: | |||
| f = lambda: self._mgr.is_numeric_mixed_type | |||
| return self._protect_consolidate(f) | |||
| return self._mgr.is_numeric_mixed_type | |||
There was a problem hiding this comment.
Since this property is only used in the function right below, I would just inline the self._mgr.is_numeric_mixed_type there
…rf-protect_consolidate-less
jorisvandenbossche
approved these changes
Jun 10, 2020
…rf-protect_consolidate-less
|
rebased+green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.