Skip to content

ERR: Fix to_timedelta error message #34981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2020
Merged

ERR: Fix to_timedelta error message #34981

merged 5 commits into from
Jun 26, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Jun 24, 2020

Error messages were missing a case (unit of "y")

@mroeschke mroeschke added Error Reporting Incorrect or improved errors from pandas Timedelta Timedelta data type labels Jun 26, 2020
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure looks unrelated. Maybe merge in master again?

@mroeschke mroeschke added this to the 1.1 milestone Jun 26, 2020
@jreback jreback merged commit a347e76 into pandas-dev:master Jun 26, 2020
@jreback
Copy link
Contributor

jreback commented Jun 26, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the timedelta-error branch June 26, 2020 22:12
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants