Skip to content

BUG: HDFStore unable to create colindex w/o error thrown #34983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arw2019
Copy link
Member

@arw2019 arw2019 commented Jun 25, 2020

I found this discussion of the data_columns argument to pd.HDFStore.create_table_index really useful:
https://pandas.pydata.org/pandas-docs/stable/user_guide/io.html#query-via-data-columns

@arw2019 arw2019 marked this pull request as draft June 25, 2020 03:36
@arw2019 arw2019 marked this pull request as ready for review June 25, 2020 04:40
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test comments, code change looks good

@jreback jreback added Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore labels Jun 25, 2020
@arw2019 arw2019 requested a review from jreback June 26, 2020 17:07
@jreback jreback added this to the 1.1 milestone Jun 29, 2020
@jreback jreback merged commit b1b70c7 into pandas-dev:master Jun 30, 2020
@jreback
Copy link
Contributor

jreback commented Jun 30, 2020

thanks @arw2019 very nice!

@arw2019 arw2019 deleted the hdfStore-unable-to-create-index-no-error branch June 30, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDFStore: unable to create index, no error message
2 participants