-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: fix union_indexes not supporting sort=False for Index subclasses #35098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
148a589
BUG: fix index detection in _sanitize_and_check
AlexKirko 8a51ded
DOC: add comment to fix
AlexKirko 371fd6e
TST: add tests
AlexKirko e5f1e68
DOC: add whatsnew entry
AlexKirko 9701bb5
REFACT: refact the boolean expression
AlexKirko 3208fbe
REFACT: use generator comprehension
AlexKirko a15cef4
TST: add cases to the test
AlexKirko 933956c
preserve Index subclass, exclude MultiIndex
AlexKirko 4ecd83e
include RangeIndex in exceptions
AlexKirko 896d62a
exclude DatetimeIndex
AlexKirko 950b279
exclude CategoricalIndex
AlexKirko 4b2076d
CLN: sort imports in test_common
AlexKirko 6f2f3c9
DOC: remove unnecessary backquoutes in whatsnew
AlexKirko 0a6c62e
DOC: add missing colon to whatsnew
AlexKirko 9ca48f7
pass sort to Index.union instead of previous approach
AlexKirko f41b7e7
explicitly ignore sort for heavily modified Index subclasses
AlexKirko 2fe2c9d
fully incorporate sort ignoring for particular Index subtypes
AlexKirko cefd5c9
CLN: fix typo
AlexKirko 605ac21
CLN: switch ind_types to list comprehension
AlexKirko 18abbae
test without DatetimeIndex and CategoricalIndex in exceptions
AlexKirko 81116d4
test without multi, range, datetime in exceptions
AlexKirko a7ec4bf
return MultiIndex, RangeIndex, CategoricalIndex to exceptions
AlexKirko e85529d
CLN: black indexes/api.py
AlexKirko 683f615
Merge branch 'master' into append-err-sort
AlexKirko c76859e
restart tests
AlexKirko 11773a5
Merge branch 'master' into append-err-sort
AlexKirko 836fc1a
Merge branch 'master' into append-err-sort: pin isort and sphinx
AlexKirko b9d5ab4
add DatetimeIndex back into exceptions
AlexKirko ee7048e
DOC: move to Reshaping in whatsnew and edit
AlexKirko 1f67a3c
pass sort through to all Index subclasses
AlexKirko c722154
TST: alter test_construct_with_two_categoricalindex_series
AlexKirko ab291a7
TST: alter test_str_cat_align_mixed_inputs
AlexKirko 93a4ccc
TST: alter test_unbalanced in test_melt
AlexKirko 93452c1
TST: alter nonnumeric and float suffix tests in test_melt
AlexKirko fb3a906
CLN: run black pandas
AlexKirko 0479618
TST: add OP test, use fixture in the index test
AlexKirko 0f96dbe
CLN: run black on test files
AlexKirko ada7346
REFACT: remove unnecessary change of sort from True to None
AlexKirko c3cbecc
Revert "REFACT: remove unnecessary change of sort from True to None"
AlexKirko 7cc4d9d
restart tests
AlexKirko 4c1cc42
DOC: add comment with ref to sort=None issue
AlexKirko cc0d167
DOC: clarify comment language
AlexKirko 54140af
DOC: clarify comment more
AlexKirko 1c371bd
restart tests
AlexKirko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.