Skip to content

TYP, DOC, CLN:SeriesGroupBy._wrap_applied_output #35120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jul 4, 2020

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@MarcoGorelli MarcoGorelli requested a review from WillAyd July 4, 2020 12:54
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but I think generally OK. There might be some overlap here with what @TomAugspurger is working on

@WillAyd WillAyd added Groupby Typing type annotations, mypy/pyright type checking labels Jul 6, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomAugspurger TomAugspurger merged commit 08eca21 into pandas-dev:master Jul 7, 2020
@TomAugspurger
Copy link
Contributor

Thanks @MarcoGorelli.

@TomAugspurger TomAugspurger added this to the 1.1 milestone Jul 7, 2020
@MarcoGorelli MarcoGorelli deleted the typ-cln-seriesgroupbywrapappliedoutput branch July 7, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants