Skip to content

BUG: validate index/data length match in DataFrame construction #35590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Bug Constructors Series/DataFrame/Index/pd.array Constructors labels Aug 6, 2020
@jreback jreback added this to the 1.2 milestone Aug 6, 2020
@@ -50,6 +50,10 @@ Categorical

-

**Other**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put in 1.2? (also don't put in other generally)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is this a regression / easy patch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think its a regression, but it is a bugfix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok its in 1.1.1 that's ok

@jreback jreback modified the milestones: 1.2, 1.1.1 Aug 7, 2020
@jreback
Copy link
Contributor

jreback commented Aug 7, 2020

ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 71b5650 into pandas-dev:master Aug 7, 2020
@jbrockmendel jbrockmendel deleted the bug-33437 branch August 7, 2020 02:20
@jreback
Copy link
Contributor

jreback commented Aug 7, 2020

hmm this didn't backport

@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 7, 2020
simonjayhawkins pushed a commit that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Constructors Series/DataFrame/Index/pd.array Constructors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame constructor doesn't validate index/data lengths with EA data
3 participants