Skip to content

DOC: Fix code of conduct link #35857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Aug 23, 2020
Merged

DOC: Fix code of conduct link #35857

merged 1 commit into from Aug 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2020

closes #35855

@alimcmaster1
Copy link
Member

LGTM - does this now work if you build the docs locally?

@ghost
Copy link
Author

ghost commented Aug 22, 2020

LGTM - does this now work if you build the docs locally?

Yes! Built via ./pandas_web.py pandas. Here is my best attempt at test evidence (note on hover showing corrected link in bottom left)

Screen Shot 2020-08-22 at 4 18 57 PM

alimcmaster1
alimcmaster1 approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the evidence!

@MarcoGorelli MarcoGorelli added this to the 1.2 milestone Aug 23, 2020
@MarcoGorelli
Copy link
Member

I too built this locally and can confirm it works - thanks @21CSM, and welcome!

@MarcoGorelli MarcoGorelli merged commit eca6068 into pandas-dev:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DOC: code of conduct link doesn't work
2 participants
@alimcmaster1 @MarcoGorelli