-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Fix DataFrame.groupby().apply() for NaN groups with dropna=False #35951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 13 commits into
pandas-dev:master
from
cwkwong:gh35889-groupby-dropna-apply
Sep 5, 2020
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ac7c99a
BUG: add unit test, should fail (#35889)
cwkwong 6bae42a
expand tests: group with no np.nan, fix expected output (#35889)
cwkwong 26453dc
double quotes instead of single quote (#35889)
cwkwong 87dbfd9
adjust comparison: handle np.nan compare (#35889)
cwkwong 2a1e804
refactor test: handle MultiIndex dropping nan (#35889)
cwkwong 3c754d3
BUG: update rst (#35889)
cwkwong 2cc4f39
BUG: run code formatters (#35889)
cwkwong 8a2eab8
fix isort error during CI (#35889)
cwkwong aadbd75
BUG: address PR review comments (#35889)
cwkwong 311059c
forgot to run black, flake8 (#35889)
cwkwong 54c2686
Merge remote-tracking branch 'upstream/master' into gh35889-groupby-d…
cwkwong 714c81a
BUG: address review comments (#35889)
cwkwong 8439d0b
Merge remote-tracking branch 'upstream/master' into gh35889-groupby-d…
cwkwong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.