CLN: use IS64 instead of is_platform_32bit #36108 #36109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangchenli
commented
Sep 4, 2020
| @@ -72,7 +62,7 @@ def is_platform_linux() -> bool: | |||
| bool | |||
| True if the running platform is linux. | |||
| """ | |||
| return sys.platform == "linux2" | |||
| return sys.platform == "linux" | |||
There was a problem hiding this comment.
It was changed to "linux" in Python 3.3
There was a problem hiding this comment.
oh lol, i don't think this is actually used anyhow (but good to change)
fangchenli
commented
Sep 4, 2020
Comment on lines
-23
to
-30
| # ---------------------------------------------------------------------------- | ||
| # functions largely based / taken from the six module | ||
|
|
||
| # Much of the code in this module comes from Benjamin Peterson's six library. | ||
| # The license for this library can be found in LICENSES/SIX and the code can be | ||
| # found at https://bitbucket.org/gutworth/six | ||
|
|
||
|
|
There was a problem hiding this comment.
The LICENSES folder doesn't contain SIX. So I guess this comment is not valid anymore.
jreback
approved these changes
Sep 4, 2020
| @@ -72,7 +62,7 @@ def is_platform_linux() -> bool: | |||
| bool | |||
| True if the running platform is linux. | |||
| """ | |||
| return sys.platform == "linux2" | |||
| return sys.platform == "linux" | |||
There was a problem hiding this comment.
oh lol, i don't think this is actually used anyhow (but good to change)
|
thanks @VirosaLi very nice |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/compat.__init__.py#36108black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff