-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
[BUG]: Rolling.sum() calculated wrong values when axis is one and dtypes are mixed #36458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
1bc513a
a9bb0ba
58b9fed
e7d7c96
c4e83c6
1b263c6
fb85045
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,7 +243,9 @@ def _create_data(self, obj: FrameOrSeries) -> FrameOrSeries: | |
if self.on is not None and not isinstance(self.on, Index): | ||
if obj.ndim == 2: | ||
obj = obj.reindex(columns=obj.columns.difference([self.on]), copy=False) | ||
|
||
if self.axis == 1: | ||
obj = obj.astype("float64", copy=False) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add a comment with the issue number and a small explanation on why we are doing this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @jbrockmendel FYI |
||
obj._mgr = obj._mgr.consolidate() | ||
return obj | ||
|
||
def _gotitem(self, key, ndim, subset=None): | ||
|
Uh oh!
There was an error while loading. Please reload this page.