-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Closes #36541 (BUG: ValueError: cannot convert float NaN to integer when resetting MultiIndex with NaT values) #36563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d08c57c
Fixed https://github.com/pandas-dev/pandas/issues/36541
ssche 92d06ad
Merge remote-tracking branch 'upstream/master' into issue-36543
ssche c0bcc01
black pandas adjustments and added comment
ssche bb62589
Added whatsnew entry
ssche cff1e4c
Addressed review comments
ssche f012f88
Addressed isort error
ssche 47c6a29
Partial revert can't exclusively `use is_valid_nat_for_dtype`
ssche 316c28a
Merge remote-tracking branch 'upstream/master' into issue-36543
ssche 3c1d755
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche 9d3644a
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche 7127ebc
Added test cases
ssche b00d2a1
black changes
ssche 9289b39
Merge remote-tracking branch 'upstream/master' into issue-36543
ssche 8e6ca6b
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche d72df80
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche 07c8bdb
Added special handling also for timedelta kind ("m")
ssche d224768
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche 5e8cf6c
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche f301191
Merge remote-tracking branch 'upstream/master' into issue-36541
ssche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
dtype.kind in ['M', 'm']
(do the tests fail w/o this?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, they didn't before with "M" only (except for the ARM tests which I believe have an unrelated problem).
Trying with timedelta "m" now...