Skip to content

CLN: share to_native_types #36965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2020
Merged

CLN: share to_native_types #36965

merged 3 commits into from
Oct 10, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Clean label Oct 8, 2020
@jreback jreback added this to the 1.2 milestone Oct 8, 2020
@jreback
Copy link
Contributor

jreback commented Oct 8, 2020 

Performing static analysis using mypy
pandas/core/internals/blocks.py:2119: error: Definition of "to_native_types" in base class "DatetimeLikeBlockMixin" is incompatible with definition in base class "Block"  [misc]
pandas/core/internals/blocks.py:2365: error: Definition of "to_native_types" in base class "DatetimeLikeBlockMixin" is incompatible with definition in base class "Block"  [misc]
Found 2 errors in 1 file (checked 1057 source files)

@jbrockmendel
Copy link
Member Author

mypy complaints fixed; unrelated timeout

@jbrockmendel
Copy link
Member Author

Looks like this is a blocker (for mypy reasons) for the otherwise-ready branch fixing #32441

@jreback jreback merged commit 0dcef9b into pandas-dev:master Oct 10, 2020
@jbrockmendel jbrockmendel deleted the cln-to_native_types branch October 10, 2020 18:09
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: share to_native_types (pandas-dev#36965)
1dbd992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback