Skip to content

Write pickle to file-like without intermediate in-memory buffer #37056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 14, 2020
Merged

Write pickle to file-like without intermediate in-memory buffer #37056

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
54a73c5
Write pickle to file-like without intermediate storage
ig248 Oct 11, 2020
e357724
Added note in whatsnew for v1.2.0
ig248 Oct 11, 2020
82b046f
Add explicit tests for default and specific pickling protocols
ig248 Oct 11, 2020
3c1ee27
Add asv peakmem benchmark for to_pickle/from_pickle
ig248 Oct 11, 2020
f35c59d
Clean up test parametrization over supported protocols
ig248 Oct 11, 2020
7db5697
Fix linter errors
ig248 Oct 11, 2020
cccfb6e
isort imports
ig248 Oct 11, 2020
19557b4
Format whatsnew entry
ig248 Oct 12, 2020
497fa70
Merge branch 'master' into zero-copy-pickle
jreback Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/io/pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def to_pickle(
if protocol < 0:
protocol = pickle.HIGHEST_PROTOCOL
try:
f.write(pickle.dumps(obj, protocol=protocol))
pickle.dump(obj, f, protocol=protocol)
finally:
if f != filepath_or_buffer:
# do not close user-provided file objects GH 35679
Expand Down