CLN: File handling for PyArrow parquet #37828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 14, 2020
|
I'm looking into this, I fear that the docs are testing a case that isn't captured in the tests itself. |
twoertwein
commented
Nov 14, 2020
| @@ -691,6 +691,7 @@ def test_partition_cols_supported(self, pa, df_full): | |||
| dataset = pq.ParquetDataset(path, validate_schema=False) | |||
| assert len(dataset.partitions.partition_names) == 2 | |||
| assert dataset.partitions.partition_names == set(partition_cols) | |||
| assert read_parquet(path).shape == df.shape | |||
There was a problem hiding this comment.
Making sure that read_parquet is more tested when reading from a directory.
The read DataFrame has shuffled rows. Is that expected?
|
@twoertwein can you merge master and apply suggestions, ping on greenish |
|
@jreback green'ish. I think I incorporated @jorisvandenbossche comments (renamed variable and function; do not type-abuse IOHandles) |
|
thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffDe-duplicate file handling of PyArrows' parquet.