BUG: Regression in logical ops raising ValueError with Categorical columns with unused categories #38532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumns with unused categories
phofl
added
the
Regression
jreback
added
Categorical
jreback
requested changes
Dec 18, 2020
pandas/core/ops/__init__.py
Outdated
| cols = left.columns.intersection(right.columns) | ||
| # Only doing unique because of CategoricalIndex. Can be removed after | ||
| # GH#38140 is merged | ||
| cols = left.columns.intersection(right.columns).unique() |
There was a problem hiding this comment.
can you just do the intersection after L318?
There was a problem hiding this comment.
Way better, thank you very much.
jreback
approved these changes
Dec 21, 2020
|
thanks @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 21, 2020
…ValueError with Categorical columns with unused categories
jreback
pushed a commit
that referenced
this pull request
Dec 21, 2020
… with Categorical columns with unused categories (#38612) Co-authored-by: patrick <[email protected]>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…lumns with unused categories (pandas-dev#38532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@simonjayhawkins
This would fix the issue, but is pretty dirty. If we decide to merge this, we should remove this again with #38140 Also test would have to be adjusted (expected remove unused category)