Develop pre check #38663
Develop pre check #38663
Conversation
.pre-commit-config.yaml
Outdated
| - id: check-no-pd-class | ||
| name: check for pd class. | ||
| types: [python] | ||
| entry: pd.testing.assert_series_equal |
There was a problem hiding this comment.
this needs to be pd.testing.* (not exatcly sure how to do the wildcard here). cc @MarcoGorelli
There was a problem hiding this comment.
ah I see, thanks for the feed back, I'll update this.
.pre-commit-config.yaml
Outdated
| - id: check-no-pd-class | ||
| name: check for pd class. | ||
| types: [python] | ||
| entry: pd.testing. |
There was a problem hiding this comment.
suspect need to escape \ the dots
There was a problem hiding this comment.
Nice, thanks @cjlynch278 !
Could this fit into the existing non-standard-imports-in-tests check? Perhaps it could be renamed to check-unwanted-patterns-in-tests
And yes, you'll need to escape dots (pygrep uses re.search)
|
Hey @MarcoGorell and @jreback I added my changes to the existing check, implementing a wildcard. This PR should be ready for final review. In addition, I think a great approach to implementing the pre-commit library would be to not only identify problems like we do now, but to fix them automatically. We can do this using the search and replace plugin - https://github.com/mattlqx/pre-commit-search-and-replace. |
Co-authored-by: Marco Gorelli <[email protected]>
* Add the check-no-pd-class hook * make check more generic * change instance of pd.testing in test class * Update .pre-commit-config.yaml * Add wildcard to entry in pre-commit config file * Add check to import test check * Update .pre-commit-config.yaml Co-authored-by: Marco Gorelli <[email protected]> Co-authored-by: Marco Gorelli <[email protected]>
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff