REF: share Index.union #38671
Merged
REF: share Index.union #38671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 24, 2020
| @@ -3502,98 +3502,9 @@ def equal_levels(self, other) -> bool: | |||
| # -------------------------------------------------------------------- | |||
| # Set Methods | |||
|
|
|||
| def union(self, other, sort=None): | |||
There was a problem hiding this comment.
can you add these examples to the existing Index.union doc-string?
There was a problem hiding this comment.
restored + greenish
jreback
added
Index
jreback
requested changes
Dec 24, 2020
| if isinstance(self, ABCMultiIndex) and not is_object_dtype( | ||
| unpack_nested_dtype(other) | ||
| ): | ||
| raise NotImplementedError( |
| @@ -2680,6 +2727,14 @@ def union(self, other, sort=None): | |||
| right = other.astype(dtype, copy=False) | |||
| return left.union(right, sort=sort) | |||
|
|
|||
| elif not len(other) or self.equals(other): | |||
There was a problem hiding this comment.
coverage for all of these?
jreback
approved these changes
Dec 24, 2020
|
thanks would be super helpful to either disable / fix the failing travis build (it's a locale one i think) |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
* BUG: MultiIndex, IntervalIndex intersection with Categorical * standardize * Share intersection * REF: share Index.union * move doctest examples
This was referenced Apr 27, 2021
Closed
This was referenced Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.