-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: support downcasting of nullable EAs in pd.to_numeric #38746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a594847
tests
arw2019 a1bb9fc
add NumericArray path in to_numeric
arw2019 dbba7b4
replace to_numpy use with _data
arw2019 ddb71cb
review comment
arw2019 323cfdc
more testcases
arw2019 7b4180e
Merge branch 'master' of https://github.com/pandas-dev/pandas into EA…
arw2019 337589a
whatsnew
arw2019 4e8761a
review comments
arw2019 e2b4cbb
cleanup
arw2019 23c4ae6
review comments (tests)
arw2019 e140b7a
more tests
arw2019 f583a10
de-duplicate testcae
arw2019 a6cb152
more cleanup
arw2019 d707a61
review: code comments
arw2019 6b2c39f
review: code comments
arw2019 fda4ba1
review: update docstring
arw2019 1a23118
review: reorder test parameters
arw2019 1015b07
review: add testcases
arw2019 0279be9
Merge branch 'master' of https://github.com/pandas-dev/pandas into EA…
arw2019 56747da
Update pandas/core/tools/numeric.py
arw2019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -725,3 +725,34 @@ def test_to_numeric_from_nullable_string(values, expected): | |
s = Series(values, dtype="string") | ||
result = to_numeric(s) | ||
tm.assert_series_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"data, input_dtype, downcast, expected_dtype", | ||
( | ||
([1, 1], "Int64", "integer", "Int8"), | ||
([1.0, 1.0], "Float64", "integer", "Int8"), | ||
arw2019 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
([1.0, 1.1], "Float64", "integer", "Float64"), | ||
([1, pd.NA], "Int64", "integer", "Int8"), | ||
([450, 300], "Int64", "integer", "Int16"), | ||
([1, 1], "Int64", "signed", "Int8"), | ||
([1.0, 1.0], "Float32", "signed", "Int8"), | ||
([1.0, 1.1], "Float64", "signed", "Float64"), | ||
([1, pd.NA], "Int64", "signed", "Int8"), | ||
jreback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
([450, -300], "Int64", "signed", "Int16"), | ||
([1, 1], "Int64", "unsigned", "UInt8"), | ||
([1.0, 1.0], "Float32", "unsigned", "UInt8"), | ||
([1.0, 1.1], "Float64", "unsigned", "Float64"), | ||
([1, pd.NA], "Int64", "unsigned", "UInt8"), | ||
([450, -300], "Int64", "unsigned", "Int64"), | ||
([-1, -1], "Int32", "unsigned", "Int32"), | ||
([1, 1], "Float64", "float", "Float32"), | ||
([1, 1.1], "Float64", "float", "Float32"), | ||
([1, 1], "Float64", "integer", "Int8"), | ||
arw2019 marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: maybe move this one up to the other "integer" downcast cases There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
), | ||
) | ||
def test_downcast_nullable_numeric(data, input_dtype, downcast, expected_dtype): | ||
arr = pd.array(data, dtype=input_dtype) | ||
result = pd.to_numeric(arr, downcast=downcast) | ||
expected = pd.array(data, dtype=expected_dtype) | ||
tm.assert_extension_array_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.