Skip to content

MAINT: regex char class improve #38817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

tylerjereddy
Copy link
Contributor

  • remove superfluous regex character classes
    from the codebase (those that contain a single
    character incur the overhead of a class with
    none of the advantages of a class)

  • for more details, see similar change in NumPy:
    MAINT: regex char class improve numpy/numpy#18083

  • check performed with some simple scraping code

* remove superfluous regex character classes
from the codebase (those that contain a single
character incur the overhead of a class with
none of the advantages of a class)

* for more details, see similar change in NumPy:
numpy/numpy#18083
@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 30, 2020
@jreback jreback added this to the 1.3 milestone Dec 30, 2020
@jreback jreback merged commit 413fc95 into pandas-dev:master Dec 30, 2020
@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

thanks @tylerjereddy

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants