Skip to content

CLN: use getvalue() instead of seek(0)+read() #39213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021
Merged

CLN: use getvalue() instead of seek(0)+read() #39213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 11 additions & 22 deletions pandas/io/stata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,7 @@ def generate_value_label(self, byteorder: str) -> bytes:
for text in self.txt:
bio.write(text + null_byte)

bio.seek(0)
return bio.read()
return bio.getvalue()


class StataMissingValue:
Expand Down Expand Up @@ -2933,8 +2932,7 @@ def generate_blob(self, gso_table: Dict[str, Tuple[int, int]]) -> bytes:
bio.write(utf8_string)
bio.write(null)

bio.seek(0)
return bio.read()
return bio.getvalue()


class StataWriter117(StataWriter):
Expand Down Expand Up @@ -3128,8 +3126,7 @@ def _write_header(
# '\x11' added due to inspection of Stata file
stata_ts = b"\x11" + bytes(ts, "utf-8")
bio.write(self._tag(stata_ts, "timestamp"))
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "header"))
self._write_bytes(self._tag(bio.getvalue(), "header"))

def _write_map(self) -> None:
"""
Expand Down Expand Up @@ -3159,16 +3156,14 @@ def _write_map(self) -> None:
bio = BytesIO()
for val in self._map.values():
bio.write(struct.pack(self._byteorder + "Q", val))
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "map"))
self._write_bytes(self._tag(bio.getvalue(), "map"))

def _write_variable_types(self) -> None:
self._update_map("variable_types")
bio = BytesIO()
for typ in self.typlist:
bio.write(struct.pack(self._byteorder + "H", typ))
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "variable_types"))
self._write_bytes(self._tag(bio.getvalue(), "variable_types"))

def _write_varnames(self) -> None:
self._update_map("varnames")
Expand All @@ -3179,8 +3174,7 @@ def _write_varnames(self) -> None:
name = self._null_terminate_str(name)
name = _pad_bytes_new(name[:32].encode(self._encoding), vn_len + 1)
bio.write(name)
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "varnames"))
self._write_bytes(self._tag(bio.getvalue(), "varnames"))

def _write_sortlist(self) -> None:
self._update_map("sortlist")
Expand All @@ -3193,8 +3187,7 @@ def _write_formats(self) -> None:
fmt_len = 49 if self._dta_version == 117 else 57
for fmt in self.fmtlist:
bio.write(_pad_bytes_new(fmt.encode(self._encoding), fmt_len))
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "formats"))
self._write_bytes(self._tag(bio.getvalue(), "formats"))

def _write_value_label_names(self) -> None:
self._update_map("value_label_names")
Expand All @@ -3209,8 +3202,7 @@ def _write_value_label_names(self) -> None:
name = self._null_terminate_str(name)
encoded_name = _pad_bytes_new(name[:32].encode(self._encoding), vl_len + 1)
bio.write(encoded_name)
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "value_label_names"))
self._write_bytes(self._tag(bio.getvalue(), "value_label_names"))

def _write_variable_labels(self) -> None:
# Missing labels are 80 blank characters plus null termination
Expand All @@ -3223,8 +3215,7 @@ def _write_variable_labels(self) -> None:
if self._variable_labels is None:
for _ in range(self.nvar):
bio.write(blank)
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "variable_labels"))
self._write_bytes(self._tag(bio.getvalue(), "variable_labels"))
return

for col in self.data:
Expand All @@ -3243,8 +3234,7 @@ def _write_variable_labels(self) -> None:
bio.write(_pad_bytes_new(encoded, vl_len + 1))
else:
bio.write(blank)
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "variable_labels"))
self._write_bytes(self._tag(bio.getvalue(), "variable_labels"))

def _write_characteristics(self) -> None:
self._update_map("characteristics")
Expand All @@ -3271,8 +3261,7 @@ def _write_value_labels(self) -> None:
lab = vl.generate_value_label(self._byteorder)
lab = self._tag(lab, "lbl")
bio.write(lab)
bio.seek(0)
self._write_bytes(self._tag(bio.read(), "value_labels"))
self._write_bytes(self._tag(bio.getvalue(), "value_labels"))

def _write_file_close_tag(self) -> None:
self._update_map("stata_data_close")
Expand Down