BUG: RangeIndex concatenating incorrectly a single object of length 1 #39439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnnaDaglis
commented
Jan 27, 2021
AnnaDaglis
commented
- closes ValueError when concatenating a length-one, reversed object #39401
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -294,6 +294,7 @@ Indexing | |||
| - Bug in setting ``timedelta64`` values into numeric :class:`Series` failing to cast to object dtype (:issue:`39086`) | |||
| - Bug in setting :class:`Interval` values into a :class:`Series` or :class:`DataFrame` with mismatched :class:`IntervalDtype` incorrectly casting the new values to the existing dtype (:issue:`39120`) | |||
| - Bug in incorrectly raising in :meth:`Index.insert`, when setting a new column that cannot be held in the existing ``frame.columns``, or in :meth:`Series.reset_index` or :meth:`DataFrame.reset_index` instead of casting to a compatible dtype (:issue:`39068`) | |||
| - Bug in :meth:`RangeIndex._concat` where a single object of length 1 was concatenated incorrectly (:issue:`39401`) | |||
There was a problem hiding this comment.
is there a user-facing method that we can reference instead of RangeIndex._concat?
There was a problem hiding this comment.
RangeIndex.append method is making use of RangeIndex._concat. We can reference it instead.
jreback
requested changes
Jan 28, 2021
|
@jreback All green! Good to merge? |
jreback
approved these changes
Jan 28, 2021
|
thanks @AnnaDaglis very nice. keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.