Skip to content

fix benchmark failure with numpy 1.20+ #39795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2021
Merged

fix benchmark failure with numpy 1.20+ #39795

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a6ff21
fix benchmark failure with numpy 1.20+
simonjayhawkins Feb 13, 2021
9bc7955
instead raise a NotImplementedError
simonjayhawkins Feb 16, 2021
24ebb4f
Merge remote-tracking branch 'upstream/master' into benchmark-new-numpy
simonjayhawkins Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/series_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def time_isin_long_series_long_values_floats(self):

class IsInLongSeriesLookUpDominates:
params = [
["int64", "int32", "float64", "float32", "object", "Int64", "Float64"],
["int64", "int32", "float64", "float32", "object"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead raise a NotImplementedError in the setup below if dtype in ("Int64", "Float64") and np.__version >+ "1.20.0" ?

That keeps the benchmark running for if you don't have numpy 1.20 installed (although I don't know how often the environment gets updated on our benchmark server)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorisvandenbossche . done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Further follow-up question: 1) is there actually an issue about this failure? 2) can you add a link to that issue as a TODO comment where raising the NotImplementedError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there actually an issue about this failure?

#39844

can you add a link to that issue as a TODO comment where raising the NotImplementedError?

as a follow-up

[5, 1000],
["random_hits", "random_misses", "monotone_hits", "monotone_misses"],
]
Expand Down