Skip to content

TST/REF: Consolidate tests in apply.test_invalid_arg #40092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Moves relevant tests into test_invalid_arg. Had to rename two tests because they were of the same name, but no other changes. I organized the file by the reason for the exception, and indicated this at the top of the file. Certainly open to any other ways of organizing.

@rhshadrach rhshadrach added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite Apply Apply, Aggregate, Transform, Map labels Feb 26, 2021
@jreback jreback added this to the 1.3 milestone Feb 26, 2021
@jreback
Copy link
Contributor

jreback commented Feb 26, 2021

great. can you merge master to assure no actual failtures, ping on green.

@jreback
Copy link
Contributor

jreback commented Feb 27, 2021

lgtm. can you merge master.

…ply_invalid_arg

� Conflicts:
�	pandas/tests/apply/test_series_transform.py
@jreback jreback merged commit 2aa1ab4 into pandas-dev:master Mar 3, 2021
@jreback
Copy link
Contributor

jreback commented Mar 3, 2021

thanks @rhshadrach

@rhshadrach rhshadrach deleted the apply_invalid_arg branch March 3, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants