REF: simplify ohlc #41091
Merged
REF: simplify ohlc #41091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
approved these changes
Apr 22, 2021
pandas/core/groupby/groupby.py
Outdated
| assert result.ndim == 1 | ||
| key = base.OutputKey(label=name, position=idx) | ||
| output[key] = result | ||
| idx += 1 |
There was a problem hiding this comment.
There's an OHLC specific comment on L1098 that probably isn't relevant anymore (suggests using enumerate, but I guess that's still not possible because of the continue early in the loop).
There was a problem hiding this comment.
yah, i was counting that as part of the "simplify _wrap_aggregated_output" follow-up
|
merged the other one, pls rebase |
|
rebased + greenish (unrelated pyarrow failure thats failing on everything) |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or more accurately, simplify BaseGroupBy._cython_agg_general by not having ohlc go through it. This will in turn allow us to simplify SeriesGroupBy._wrap_aggregated_output.
This will have a merge conflict with #41066. Doesn't matter which order they are merged in.