Skip to content

REF: mix NDArrayBacked into Categorical, PandasArray #41131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the ExtensionArray Extending pandas with custom dtypes or arrays. label Apr 26, 2021
@jreback
Copy link
Contributor

jreback commented Apr 26, 2021

does this have any perf implications?

pls rebase

@jbrockmendel
Copy link
Member Author

does this have any perf implications?

In [3]: cat = pd.Categorical(range(5))

In [4]: %timeit cat.copy()
315 ns ± 5.19 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)  <-- PR
802 ns ± 7.08 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)  <-- master

@jbrockmendel
Copy link
Member Author

Rebased + green

@jreback jreback added this to the 1.3 milestone May 5, 2021
@jreback jreback merged commit f97d61c into pandas-dev:master May 5, 2021
@jreback
Copy link
Contributor

jreback commented May 5, 2021

great!

@jbrockmendel jbrockmendel deleted the perf-ndarray-backed-6 branch May 5, 2021 14:49
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants