Skip to content

Deprecate inplace in Categorical.rename_categories #41186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2021
Merged

Deprecate inplace in Categorical.rename_categories #41186

merged 2 commits into from
May 2, 2021

Conversation

OlehKSS
Copy link
Contributor

@OlehKSS OlehKSS commented Apr 27, 2021

@jbrockmendel
Copy link
Member

need to do tm.assert_produces_warning in some of the existing tests i think

@OlehKSS
Copy link
Contributor Author

OlehKSS commented Apr 27, 2021

need to do tm.assert_produces_warning in some of the existing tests i think

As far as I see, the failed CI task treats warnings as errors. I will check which tests should be changed

@jreback jreback added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Apr 30, 2021
@jreback jreback added this to the 1.3 milestone Apr 30, 2021
@jreback
Copy link
Contributor

jreback commented Apr 30, 2021

yeah pls assert the warning o nthe failing tests and ping on green

@OlehKSS
Copy link
Contributor Author

OlehKSS commented May 1, 2021

@jbrockmendel @jreback
I fixed the uncaught warning issues, all checks are green.

jbrockmendel
jbrockmendel approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit c556c20 into pandas-dev:master May 2, 2021
@jreback
Copy link
Contributor

jreback commented May 2, 2021

thanks @OlehKSS

yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
@OlehKSS @yeshsurya
Deprecate inplace in Categorical.rename_categories (pandas-dev#41186)
20d46fd
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@OlehKSS @JulianWgs
Deprecate inplace in Categorical.rename_categories (pandas-dev#41186)
48d1b9f
@jbrockmendel jbrockmendel mentioned this pull request Oct 2, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@OlehKSS @jbrockmendel @jreback