Skip to content

TYP: Fix typing in ExtensionDtype registry #41203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 3, 2021
Merged

TYP: Fix typing in ExtensionDtype registry #41203

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7d4531d
TYP: Fix typing in ExtensionDtype registry
Dr-Irv Apr 28, 2021
41c5355
fix construct_from_string return type
Dr-Irv Apr 28, 2021
03d4e66
overloads for find. typing cls in ExtensionDtype
Dr-Irv Apr 28, 2021
7f51bf0
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv May 23, 2021
1a71e71
fixes to use more of ExtensionDtypeT
Dr-Irv May 23, 2021
bd21368
Merge branch 'master' into extensionv1
Dr-Irv May 31, 2021
d7803f0
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Jul 1, 2021
246ee33
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Jul 3, 2021
37affba
use type_t, reduce overloads, use npt.DTypeLike
Dr-Irv Jul 3, 2021
3174b0f
undo use of npt and put back type_t[ExtensionDtype]
Dr-Irv Jul 3, 2021
4d6dbdb
cast to the union
Dr-Irv Jul 3, 2021
eaefa6c
remove Union in cast
Dr-Irv Jul 3, 2021
9b295a2
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Jul 4, 2021
d9651a4
add 4th overload
Dr-Irv Jul 4, 2021
b72f9dd
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Jul 28, 2021
00092c0
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Jul 29, 2021
c4deaa0
Merge remote-tracking branch 'upstream/master' into extensionv1
Dr-Irv Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/dtypes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from pandas._typing import (
DtypeObj,
NpDtype,
Union,
type_t,
)
from pandas.errors import AbstractMethodError
Expand Down Expand Up @@ -465,8 +466,8 @@ def find(
dtype_type = dtype
if issubclass(dtype_type, ExtensionDtype):
# cast needed here as mypy doesn't know we have figured
# out it is an ExtensionDtype
return cast(ExtensionDtype, dtype)
# out it is an ExtensionDtype or type_t[ExtensionDtype]
return cast(Union[ExtensionDtype, type_t[ExtensionDtype]], dtype)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, to avoid adding the Union import, i have a preference for,

Suggested change
return cast(Union[ExtensionDtype, type_t[ExtensionDtype]], dtype)
return cast("ExtensionDtype | type_t[ExtensionDtype]", dtype)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in next commit


return None

Expand Down