Skip to content

REF: raise more selectively in libreduction #41298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

REF: raise more selectively in libreduction #41298

merged 2 commits into from
May 4, 2021

Conversation

jbrockmendel
Copy link
Member

This allows slightly more cases to go through the cython path

@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label May 4, 2021
@jreback jreback added this to the 1.3 milestone May 4, 2021
@jreback jreback added the Reduction Operations sum, mean, min, max, etc. label May 4, 2021
@jreback
Copy link
Contributor

jreback commented May 4, 2021

i suppose then perf diff?

@jbrockmendel
Copy link
Member Author

i suppose then perf diff?

presumably. havent measured since its such a tiny corner case thats affected (1 test)

@jreback jreback merged commit bb636d9 into pandas-dev:master May 4, 2021
@jbrockmendel jbrockmendel deleted the ref-libreduction-5 branch May 4, 2021 19:40
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: raise more selectively in libreduction (pandas-dev#41298)
95bb654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reduction Operations sum, mean, min, max, etc. Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback