Skip to content

TYP: BaseWindowGroupby._grouper #41299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

TYP: BaseWindowGroupby._grouper #41299

merged 1 commit into from
May 4, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding labels May 4, 2021
jreback
jreback requested changes May 4, 2021
View reviewed changes
pandas/core/window/rolling.py
**kwargs,
):
if _grouper is None:
raise ValueError("Must pass a Grouper object.")
from pandas.core.groupby.ops import BaseGrouper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you reallly need this import (as this is imported above right?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its imported above inside a if TYPE_CHECKING; importing it at the module level raises bc of circularity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i c, ok

@jreback jreback added this to the 1.3 milestone May 4, 2021
@jreback jreback merged commit 53b7fff into pandas-dev:master May 4, 2021
@jbrockmendel jbrockmendel deleted the typ-window-grouper branch May 4, 2021 19:38
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
TYP: BaseWindowGroupby._grouper (pandas-dev#41299)
3773d1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback