Skip to content

Add warning about NA merges #42865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Add warning about NA merges #42865

merged 2 commits into from
Aug 19, 2021

Conversation

kasuteru
Copy link
Contributor

@kasuteru kasuteru commented Aug 3, 2021

This is in reference to #32306.

While the discussion on how to fix this is still ongoing, a warning will help users to at least know about this and take the appropriate precautions.

@kasuteru kasuteru marked this pull request as ready for review August 3, 2021 13:05
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@jreback jreback added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Aug 5, 2021
@jreback jreback added this to the 1.4 milestone Aug 5, 2021
@jreback
Copy link
Contributor

jreback commented Aug 19, 2021

@pandas-dev/pandas-core if any comments.

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback merged commit aa20c8a into pandas-dev:master Aug 19, 2021
@jreback
Copy link
Contributor

jreback commented Aug 19, 2021

thanks @kasuteru

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants