Skip to content

BUG: read_fwf raise if len colspec doesnt match len names #42920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 31, 2021
Merged

BUG: read_fwf raise if len colspec doesnt match len names #42920

merged 10 commits into from
Aug 31, 2021

Conversation

debnathshoham
Copy link
Member

@debnathshoham debnathshoham commented Aug 6, 2021 •
edited
Loading

@debnathshoham debnathshoham marked this pull request as draft August 7, 2021 06:34
@debnathshoham debnathshoham marked this pull request as ready for review August 7, 2021 10:46
mzeitlin11
mzeitlin11 reviewed Aug 7, 2021
View reviewed changes
Copy link
Member

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @debnathshoham! Some initial comments

@mzeitlin11 mzeitlin11 added Error Reporting Incorrect or improved errors from pandas IO Fixed Width read_fwf labels Aug 7, 2021
mzeitlin11
mzeitlin11 reviewed Aug 8, 2021
View reviewed changes
@jreback jreback added this to the 1.4 milestone Aug 19, 2021
@jreback
Copy link
Contributor

jreback commented Aug 19, 2021

@mzeitlin11 how's this look?

@mzeitlin11
Copy link
Member

@mzeitlin11 how's this look?

Sorry for delay, this LGTM, caveat that not too familiar with read_fwf, but with all the awesome added test coverage all these paths are exercised

@jreback jreback merged commit 1625f28 into pandas-dev:master Aug 31, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

thanks @debnathshoham

@debnathshoham debnathshoham deleted the gh40830 branch September 1, 2021 05:46
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@debnathshoham @feefladder
BUG: read_fwf raise if len colspec doesnt match len names (pandas-dev…
eaf6f69 
…#42920)
@xnx xnx mentioned this pull request Mar 31, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeitlin11 mzeitlin11 mzeitlin11 approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO Fixed Width read_fwf
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: pandas.read_fwf does not throw warning or error when column spec and name list lengths differ
3 participants
@debnathshoham @jreback @mzeitlin11