Skip to content

BUG: pd.to_datetime with format doesn't work with pd.NA #42982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 25, 2021
Merged

BUG: pd.to_datetime with format doesn't work with pd.NA #42982

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a94fd28
BUG: pd.to_datetime with format doesn't work with pd.NA
debnathshoham Aug 11, 2021
f65f0de
raised if no pd.NA
debnathshoham Aug 11, 2021
a1736a9
included pd.na check
debnathshoham Aug 11, 2021
a0f9e74
added whatsnew and tests
debnathshoham Aug 11, 2021
cf4119d
added couple more test cases
debnathshoham Aug 11, 2021
74a8e95
added suggested testcases
debnathshoham Aug 11, 2021
58c6d1e
Merge branch 'master' into gh42957
debnathshoham Aug 20, 2021
c8aaf04
Merge branch 'master' into gh42957
debnathshoham Aug 30, 2021
3d617e1
resolved conflict in whatsnew
debnathshoham Sep 3, 2021
10d36db
Merge branch 'gh42957' of https://github.com/debnathshoham/pandas int…
debnathshoham Sep 3, 2021
be5cdc1
Merge branch 'master' into gh42957
debnathshoham Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.4.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ Categorical
Datetimelike
^^^^^^^^^^^^
- Bug in :class:`DataFrame` constructor unnecessarily copying non-datetimelike 2D object arrays (:issue:`39272`)
-
- Bug in :func:`to_datetime` with ``format`` and ``pandas.NA`` was raising ``ValueError`` (:issue:`42957`)

Timedelta
^^^^^^^^^
Expand Down
4 changes: 2 additions & 2 deletions pandas/_libs/tslibs/strptime.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ from numpy cimport (
ndarray,
)

from pandas._libs.missing cimport checknull_with_nat_and_na
from pandas._libs.tslibs.nattype cimport (
NPY_NAT,
c_nat_strings as nat_strings,
checknull_with_nat,
)
from pandas._libs.tslibs.np_datetime cimport (
check_dts_bounds,
Expand Down Expand Up @@ -134,7 +134,7 @@ def array_strptime(ndarray[object] values, object fmt, bint exact=True, errors='
iresult[i] = NPY_NAT
continue
else:
if checknull_with_nat(val):
if checknull_with_nat_and_na(val):
iresult[i] = NPY_NAT
continue
else:
Expand Down
20 changes: 20 additions & 0 deletions pandas/tests/tools/test_to_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,26 @@ def test_to_datetime_parse_timezone_keeps_name(self):
expected = DatetimeIndex(["2010-01-01 12:00:00"], tz="UTC", name="foo")
tm.assert_index_equal(result, expected)

@pytest.mark.parametrize(
"data, format, expected",
[
([pd.NA], "%Y%m%d%H%M%S", DatetimeIndex(["NaT"])),
([pd.NA], None, DatetimeIndex(["NaT"])),
(
[pd.NA, "20210202202020"],
"%Y%m%d%H%M%S",
DatetimeIndex(["NaT", "2021-02-02 20:20:20"]),
),
(["201010", pd.NA], "%y%m%d", DatetimeIndex(["2020-10-10", "NaT"])),
(["201010", pd.NA], "%d%m%y", DatetimeIndex(["2010-10-20", "NaT"])),
(["201010", pd.NA], None, DatetimeIndex(["2010-10-20", "NaT"])),
],
)
def test_to_datetime_with_pdNA(self, data, format, expected):
# GH#42957
result = to_datetime(data, format=format)
tm.assert_index_equal(result, expected)


class TestToDatetime:
@pytest.mark.parametrize(
Expand Down