Skip to content

TST: Adding unit tests for named indexes resulting from empty datafra… #43593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 31, 2021
45 changes: 45 additions & 0 deletions pandas/tests/groupby/test_groupby_shift_emptydf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import numpy as np
import pytest

from pandas import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls don't make a new file, look for a similar test in this directory and put it near.

DataFrame
)

import pandas._testing as tm

def test_empty_shift_with_fill():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referencde the original issue in a comment

#This test is designed to replicate the extra named indexes in 41264 caused by having a fill_value parameter

empty_df = DataFrame(columns=["a", "b", "c"])

shifted = empty_df.groupby(['a']).shift(1)
shifted_with_fill = empty_df.groupby(['a']).shift(1, fill_value=0)

tm.assert_frame_equal(shifted, shifted_with_fill)
tm.assert_index_equal(shifted.index, shifted_with_fill.index)

def test_multindex_empty_shift_with_fill():
#This test is designed to replicate the extra named indexes in 41264 caused by having a fill_value parameter for multindexes

empty_df = DataFrame(columns=["a", "b", "c"])

shifted = empty_df.groupby(['a','b']).shift(1)
shifted_with_fill = empty_df.groupby(['a','b']).shift(1, fill_value=0)

tm.assert_frame_equal(shifted, shifted_with_fill)
tm.assert_index_equal(shifted.index, shifted_with_fill.index)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you can parameterize some of these

def test_multindex_shift_with_fill():
#This test is designed to replicate the extra named indexes in 41264.
#Both numbered dataframes and empty dataframes should return FrozenList([None])

num_df = DataFrame({'a':[1,2,3], 'b':[4,5,6], 'c':[7,8,9]})
empty_df = DataFrame(columns=["a", "b", "c"])

shifted = empty_df.groupby(['a','b']).shift(1)
shifted_with_fill = num_df.groupby(['a','b']).shift(1, fill_value=0)

tm.assert_class_equal(shifted.index.names, shifted_with_fill.index.names)