-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: Adding unit tests for named indexes resulting from empty datafra… #43593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c8debe
TST: Adding unit tests for named indexes resulting from empty datafra…
IamJasonBian fe5ed50
Update test_groupby_shift_emptydf.py
IamJasonBian ea526c8
Delete test_groupby_shift_emptydf.py
IamJasonBian 1f6c713
Update test_groupby_shift_diff.py
IamJasonBian 62a441d
Merge branch 'pandas-dev:master' into master
IamJasonBian 6f00e9d
Update test_groupby_shift_diff.py
IamJasonBian 1e2ed71
Merge branch 'pandas-dev:master' into master
IamJasonBian b272d6c
Update test_groupby_shift_diff.py
IamJasonBian 21024d5
Merge branch 'pandas-dev:master' into master
IamJasonBian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import numpy as np | ||
import pytest | ||
|
||
from pandas import ( | ||
DataFrame | ||
) | ||
|
||
import pandas._testing as tm | ||
|
||
def test_empty_shift_with_fill(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. referencde the original issue in a comment |
||
#This test is designed to replicate the extra named indexes in 41264 caused by having a fill_value parameter | ||
|
||
empty_df = DataFrame(columns=["a", "b", "c"]) | ||
|
||
shifted = empty_df.groupby(['a']).shift(1) | ||
shifted_with_fill = empty_df.groupby(['a']).shift(1, fill_value=0) | ||
|
||
tm.assert_frame_equal(shifted, shifted_with_fill) | ||
tm.assert_index_equal(shifted.index, shifted_with_fill.index) | ||
|
||
def test_multindex_empty_shift_with_fill(): | ||
#This test is designed to replicate the extra named indexes in 41264 caused by having a fill_value parameter for multindexes | ||
|
||
empty_df = DataFrame(columns=["a", "b", "c"]) | ||
|
||
shifted = empty_df.groupby(['a','b']).shift(1) | ||
shifted_with_fill = empty_df.groupby(['a','b']).shift(1, fill_value=0) | ||
|
||
tm.assert_frame_equal(shifted, shifted_with_fill) | ||
tm.assert_index_equal(shifted.index, shifted_with_fill.index) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like you can parameterize some of these |
||
def test_multindex_shift_with_fill(): | ||
#This test is designed to replicate the extra named indexes in 41264. | ||
#Both numbered dataframes and empty dataframes should return FrozenList([None]) | ||
|
||
num_df = DataFrame({'a':[1,2,3], 'b':[4,5,6], 'c':[7,8,9]}) | ||
empty_df = DataFrame(columns=["a", "b", "c"]) | ||
|
||
shifted = empty_df.groupby(['a','b']).shift(1) | ||
shifted_with_fill = num_df.groupby(['a','b']).shift(1, fill_value=0) | ||
|
||
tm.assert_class_equal(shifted.index.names, shifted_with_fill.index.names) | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls don't make a new file, look for a similar test in this directory and put it near.