-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Date time index.indexer between time #43602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
suyashgupta01
wants to merge
16
commits into
pandas-dev:master
from
suyashgupta01:DateTimeIndex.indexer_between_time
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ce929d2
added env to gitignore
suyashgupta01 ff83813
Merge branch 'pandas-dev:master' into master
suyashgupta01 40faba2
Merge branch 'pandas-dev:master' into master
suyashgupta01 6e3c42b
Merge branch 'pandas-dev:master' into master
suyashgupta01 2f60ba2
Merge branch 'pandas-dev:master' into master
suyashgupta01 6184049
Merge branch 'pandas-dev:master' into master
suyashgupta01 13bfd3f
Merge branch 'pandas-dev:master' into master
suyashgupta01 1479fad
generic.py modified
suyashgupta01 eac7f0c
datetimes.py modified
suyashgupta01 022a347
redundant line removed from generic.py
suyashgupta01 ccd7a97
removed env from gitignore
suyashgupta01 dd8a15c
whatsnew deprecation entry made
suyashgupta01 e4e2388
Merge branch 'master' into DateTimeIndex.indexer_between_time
suyashgupta01 8f1399c
indexer_between_time docstring modified
suyashgupta01 769cfb1
fetch and merge
suyashgupta01 efcba55
Merge branch 'master' into DateTimeIndex.indexer_between_time
suyashgupta01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is public api, need to deprecate the inlucde_start/end args.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what do I need to do here. Here's what I think I should do:
(1) Add a deprecate directive for old args (
include_start, include_end
).(2) Add a line to show deprecation of old args in
whatsnew
.An issue with (1) is that the only function calling
indexer_between_time
isbetween_time
. So, maintaining functionality with old args would just be extra code as we can just modifybetween_time
and passinclusive
instead ofinclude_start, include_end
whenindexer_between_time
is called.Please let me know what do you think @jreback :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then what you do is you change the call to
indexer_between_time`` to use the *new* api (so you don't get a deprecation warning in
between_time`